Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[http client] HttpException add isPlainText() and contentType() #277

Merged
merged 2 commits into from
Aug 24, 2023
Merged

[http client] HttpException add isPlainText() and contentType() #277

merged 2 commits into from
Aug 24, 2023

Conversation

rbygrave
Copy link
Contributor

Helper methods to make it easier for use cases that need logic in reading the HttpException that could be text or json etc

@rbygrave
[http client] HttpException add isPlainText() and contentType()
fc9b298 
Helper methods to make it easier for use cases that need logic in reading
the HttpException that could be text or json etc
SentryMan
SentryMan approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@SentryMan SentryMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SentryMan SentryMan merged commit a142f93 into master Aug 24, 2023
2 checks passed
@SentryMan SentryMan deleted the feature/HttpException-response-body branch August 24, 2023 16:06
@rbygrave rbygrave added this to the 2.0 milestone Aug 24, 2023
@rbygrave rbygrave self-assigned this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SentryMan SentryMan SentryMan approved these changes

Assignees

@rbygrave rbygrave

Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rbygrave @SentryMan